Disable example plugins on Windows#6281
Merged
Merged
Conversation
…so guard plugin example tests
Contributor
Author
|
There are many ways to solve this problem. Here are some comments about how I am solving this:
|
anmyachev
approved these changes
Mar 6, 2026
Contributor
anmyachev
left a comment
anmyachev
left a comment
There was a problem hiding this comment.
LGTM! Please open an issue for enabling plugins on Windows if we don't have it already.
Contributor
Author
Thanks! I just created an issue: #6291 |
wdziurdz
pushed a commit
that referenced
this pull request
Apr 7, 2026
* src/main: Disable example plugins on Windows (#6281)
quinnlp
added a commit
that referenced
this pull request
May 4, 2026
This reverts commit 006159c. We do not need this patch anymore because triton-lang/triton#9783 introduced a similar build option (`TRITON_EXT_ENABLED`), which is OFF by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to disable the example plugins on Windows in preparation for merging triton-lang/triton#9549 into our repo. Prior to triton-lang/triton#9549, the example plugin libraries build successfully with LLVM/MLIR's static libraries and the example plugin tests are guarded by not building against shared libs. Enabling Triton extensions/plugins on Windows is difficult: #6248 (comment).
This patch adds a CMake option
TRITON_ENABLE_PLUGINSto enable/disable building the plugin libraries inexample/plugins. It also adds a LIT config feature that reads the option to guard LIT tests that require the example plugin libraries. If the option is on, the example plugin libraries are built and the example plugin tests are enabled. If the option is off, the example plugin libraries are not built and the example plugin tests are skipped.We require that
TRITON_ENABLE_PLUGINSis set off to build on Windows. The default value of the option is OFF for Windows and ON otherwise.New contributor declaration
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsSelect one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)